winglian commited on
Commit
0c2a630
1 Parent(s): db8a8af

multipack len should use max, not min (#863)

Browse files
src/axolotl/utils/samplers/multipack.py CHANGED
@@ -181,7 +181,7 @@ class MultipackBatchSampler(BatchSampler):
181
  )
182
 
183
  # shave off 1% + 1 for dealing with variance in packing from random sampler to sampler
184
- return min(
185
  1,
186
  (
187
  world_size
 
181
  )
182
 
183
  # shave off 1% + 1 for dealing with variance in packing from random sampler to sampler
184
+ return max(
185
  1,
186
  (
187
  world_size